path: root/quote.h
diff options
authorJiang Xin <>2013-06-25 15:53:45 (GMT)
committerJunio C Hamano <>2013-06-26 18:16:48 (GMT)
commit39598f9983f759b5e38b9e762c695bad6c89a1b3 (patch)
tree77a8bc04e6224853d4c30021a249909732c5b2d0 /quote.h
parentad66df2df14991e7436474d266cc6db823e6ae78 (diff)
quote_path_relative(): remove redundant parameter
quote_path_relative() used to take a counted string as its parameter (the string to be quoted). With an earlier change, it now uses relative_path() that does not take a counted string, and we have been passing only the pointer to the string since then. Remove the length parameter from quote_path_relative() to show that this parameter was redundant. All the changed lines show that the caller passed either -1 (to ask the function run strlen() on the string), or the length of the string, so the earlier conversion was safe. All the callers of quote_path_relative() that used to take counted string have been audited to make sure that they are passing length of the actual string (or -1 to ask the callee run strlen()) Signed-off-by: Jiang Xin <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'quote.h')
1 files changed, 2 insertions, 2 deletions
diff --git a/quote.h b/quote.h
index 133155a..5610159 100644
--- a/quote.h
+++ b/quote.h
@@ -65,8 +65,8 @@ extern void write_name_quoted_relative(const char *name, size_t len,
FILE *fp, int terminator);
/* quote path as relative to the given prefix */
-extern char *quote_path_relative(const char *in, int len,
- struct strbuf *out, const char *prefix);
+extern char *quote_path_relative(const char *in, const char *prefix,
+ struct strbuf *out);
/* quoting as a string literal for other languages */
extern void perl_quote_print(FILE *stream, const char *src);