path: root/progress.h
diff options
authorSZEDER Gábor <>2019-04-05 00:45:36 (GMT)
committerJunio C Hamano <>2019-04-05 06:02:06 (GMT)
commit9219d12777baf67e001329cad98fa21c55d46b2e (patch)
tree4c85f52b2ec35902d63c1169ffdf034ec04d134d /progress.h
parentaeb582a98374c094361cba1bd756dc6307432c42 (diff)
progress: make display_progress() return void
Ever since the progress infrastructure was introduced in 96a02f8f6d (common progress display support, 2007-04-18), display_progress() has returned an int, telling callers whether it updated the progress bar or not. However, this is: - useless, because over the last dozen years there has never been a single caller that cared about that return value. - not quite true, because it doesn't print a progress bar when running in the background, yet it returns 1; see 85cb8906f0 (progress: no progress in background, 2015-04-13). The related display_throughput() function returned void already upon its introduction in cf84d51c43 (add throughput to progress display, 2007-10-30). Let's make display_progress() return void, too. While doing so several return statements in display() become unnecessary, remove them. Signed-off-by: SZEDER Gábor <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'progress.h')
1 files changed, 1 insertions, 1 deletions
diff --git a/progress.h b/progress.h
index 70a4d4a..59e40cc 100644
--- a/progress.h
+++ b/progress.h
@@ -4,7 +4,7 @@
struct progress;
void display_throughput(struct progress *progress, uint64_t total);
-int display_progress(struct progress *progress, uint64_t n);
+void display_progress(struct progress *progress, uint64_t n);
struct progress *start_progress(const char *title, uint64_t total);
struct progress *start_delayed_progress(const char *title, uint64_t total);
void stop_progress(struct progress **progress);