summaryrefslogtreecommitdiff
path: root/perl
diff options
context:
space:
mode:
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>2021-05-26 11:21:07 (GMT)
committerJunio C Hamano <gitster@pobox.com>2021-05-27 00:00:59 (GMT)
commit7cbc0455cc07702c5eeff1062c7e2a820758714f (patch)
tree1636a198e362bd08da525356e68a3c0aa1507094 /perl
parent2815326f095a1126fe9b099c311fdde8d7b7b591 (diff)
downloadgit-7cbc0455cc07702c5eeff1062c7e2a820758714f.zip
git-7cbc0455cc07702c5eeff1062c7e2a820758714f.tar.gz
git-7cbc0455cc07702c5eeff1062c7e2a820758714f.tar.bz2
send-email: move "hooks_path" invocation to git-send-email.perl
Move the newly added "hooks_path" API in Git.pm to its only user in git-send-email.perl. This was added in c8243933c74 (git-send-email: Respect core.hooksPath setting, 2021-03-23), meaning that it hasn't yet made it into a non-rc release of git. The consensus with Git.pm is that we need to be considerate of out-of-tree users who treat it as a public documented interface. We should therefore be less willing to add new functionality to it, least we be stuck supporting it after our own uses for it disappear. In this case the git-send-email.perl hook invocation will probably be replaced by a future "git hook run" command, and in the commit preceding this one the "hooks_path" become nothing but a trivial wrapper for "rev-parse --git-path hooks" anyway (with no Cwd::abs_path() call), so let's just inline this command in git-send-email.perl itself. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'perl')
-rw-r--r--perl/Git.pm12
1 files changed, 0 insertions, 12 deletions
diff --git a/perl/Git.pm b/perl/Git.pm
index df6280e..02eacef 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -619,18 +619,6 @@ Return path to the git repository. Must be called on a repository instance.
sub repo_path { $_[0]->{opts}->{Repository} }
-=item hooks_path ()
-
-Return path to the hooks directory. Must be called on a repository instance.
-
-=cut
-
-sub hooks_path {
- my ($self) = @_;
-
- my $dir = $self->command_oneline('rev-parse', '--git-path', 'hooks');
- return $dir;
-}
=item wc_path ()