summaryrefslogtreecommitdiff
path: root/pathspec.c
diff options
context:
space:
mode:
authorRené Scharfe <l.s.r@web.de>2016-09-25 07:24:03 (GMT)
committerJunio C Hamano <gitster@pobox.com>2016-09-25 23:44:13 (GMT)
commit45ccef87b3cc0ab09ec5fd1186aa0b33298ee8d4 (patch)
tree83dffbe2e99b0fd98a286208a655012a86fb292b /pathspec.c
parent60566cbb5890abc84fa18c56da70e35ace0b23bf (diff)
downloadgit-45ccef87b3cc0ab09ec5fd1186aa0b33298ee8d4.zip
git-45ccef87b3cc0ab09ec5fd1186aa0b33298ee8d4.tar.gz
git-45ccef87b3cc0ab09ec5fd1186aa0b33298ee8d4.tar.bz2
use COPY_ARRAY
Add a semantic patch for converting certain calls of memcpy(3) to COPY_ARRAY() and apply that transformation to the code base. The result is shorter and safer code. For now only consider calls where source and destination have the same type, or in other words: easy cases. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'pathspec.c')
-rw-r--r--pathspec.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/pathspec.c b/pathspec.c
index 24e0dd5..49a5360 100644
--- a/pathspec.c
+++ b/pathspec.c
@@ -485,8 +485,7 @@ void copy_pathspec(struct pathspec *dst, const struct pathspec *src)
{
*dst = *src;
ALLOC_ARRAY(dst->items, dst->nr);
- memcpy(dst->items, src->items,
- sizeof(struct pathspec_item) * dst->nr);
+ COPY_ARRAY(dst->items, src->items, dst->nr);
}
void clear_pathspec(struct pathspec *pathspec)