path: root/packfile.h
diff options
authorJeff King <>2018-08-10 23:09:44 (GMT)
committerJunio C Hamano <>2018-08-13 20:48:25 (GMT)
commita7ff6f5a0f310406aa4973e8d7ec25815554bcb5 (patch)
tree6b2a61709b419a609a6be78e84584ad26991e55e /packfile.h
parent202e7f1e161b5bce6587d1a696843ead10a8b477 (diff)
for_each_*_object: take flag arguments as enum
It's not wrong to pass our flags in an "unsigned", as we know it will be at least as large as the enum. However, using the enum in the declaration makes it more obvious where to find the list of flags. While we're here, let's also drop the "extern" noise-words from the declarations, per our modern coding style. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'packfile.h')
1 files changed, 3 insertions, 2 deletions
diff --git a/packfile.h b/packfile.h
index 6ddc6a2..9861728 100644
--- a/packfile.h
+++ b/packfile.h
@@ -158,8 +158,9 @@ typedef int each_packed_object_fn(const struct object_id *oid,
struct packed_git *pack,
uint32_t pos,
void *data);
-extern int for_each_object_in_pack(struct packed_git *p, each_packed_object_fn, void *data);
-extern int for_each_packed_object(each_packed_object_fn, void *, unsigned flags);
+int for_each_object_in_pack(struct packed_git *p, each_packed_object_fn, void *data);
+int for_each_packed_object(each_packed_object_fn, void *,
+ enum for_each_object_flags flags);
* Return 1 if an object in a promisor packfile is or refers to the given