diff options
| author | René Scharfe <l.s.r@web.de> | 2021-08-25 20:16:46 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-08-25 21:39:08 (GMT) |
| commit | 66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a (patch) | |
| tree | 4cff22e9d61be87fc5bce6952981e8ba1c7b7127 /pack-write.c | |
| parent | a7439d0f9dd291e7cc9e6c2dda19cbfdf09b62ee (diff) | |
| download | git-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.zip git-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.tar.gz git-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.tar.bz2 | |
use xopen() to handle fatal open(2) failures
Add and apply a semantic patch for using xopen() instead of calling
open(2) and die() or die_errno() explicitly. This makes the error
messages more consistent and shortens the code.
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'pack-write.c')
| -rw-r--r-- | pack-write.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/pack-write.c b/pack-write.c index f1fc3ec..2767b78 100644 --- a/pack-write.c +++ b/pack-write.c @@ -75,9 +75,7 @@ const char *write_idx_file(const char *index_name, struct pack_idx_entry **objec index_name = strbuf_detach(&tmp_file, NULL); } else { unlink(index_name); - fd = open(index_name, O_CREAT|O_EXCL|O_WRONLY, 0600); - if (fd < 0) - die_errno("unable to create '%s'", index_name); + fd = xopen(index_name, O_CREAT|O_EXCL|O_WRONLY, 0600); } f = hashfd(fd, index_name); } @@ -256,9 +254,7 @@ const char *write_rev_file_order(const char *rev_name, rev_name = strbuf_detach(&tmp_file, NULL); } else { unlink(rev_name); - fd = open(rev_name, O_CREAT|O_EXCL|O_WRONLY, 0600); - if (fd < 0) - die_errno("unable to create '%s'", rev_name); + fd = xopen(rev_name, O_CREAT|O_EXCL|O_WRONLY, 0600); } f = hashfd(fd, rev_name); } else if (flags & WRITE_REV_VERIFY) { |