summaryrefslogtreecommitdiff
path: root/pack-bitmap.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2020-12-08 22:03:33 (GMT)
committerJunio C Hamano <gitster@pobox.com>2020-12-08 22:48:15 (GMT)
commit2978b00691c1246149892882265cd62a6921cbf5 (patch)
treec604d55968ed49e290be2e2b80d315c263dd69e2 /pack-bitmap.c
parentc5cd7490762b20cdec3844e99cfc908c38917906 (diff)
downloadgit-2978b00691c1246149892882265cd62a6921cbf5.zip
git-2978b00691c1246149892882265cd62a6921cbf5.tar.gz
git-2978b00691c1246149892882265cd62a6921cbf5.tar.bz2
rev-list: die when --test-bitmap detects a mismatch
You can use "git rev-list --test-bitmap HEAD" to check that bitmaps produce the same answer we'd get from a regular traversal. But if we detect an error, we only print "mismatch", and still exit with a successful error code. That makes the uses of --test-bitmap in the test suite (e.g., in t5310) mostly pointless: even if we saw an error, the tests wouldn't notice. Let's instead call die(), which will let these tests work as designed, and alert us if the bitmaps are bogus. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'pack-bitmap.c')
-rw-r--r--pack-bitmap.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/pack-bitmap.c b/pack-bitmap.c
index 074d9ac..4431f9f 100644
--- a/pack-bitmap.c
+++ b/pack-bitmap.c
@@ -1328,7 +1328,7 @@ void test_bitmap_walk(struct rev_info *revs)
if (bitmap_equals(result, tdata.base))
fprintf(stderr, "OK!\n");
else
- fprintf(stderr, "Mismatch!\n");
+ die("mismatch in bitmap results");
free_bitmap_index(bitmap_git);
}