diff options
| author | Junio C Hamano <gitster@pobox.com> | 2010-09-20 08:28:35 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-09-30 00:32:36 (GMT) |
| commit | 7edba4c45c33ba1e17d88907c1601dc660a44522 (patch) | |
| tree | 9760e849c006fb4a648826c83a40de6ddb8b6ebe /merge-recursive.c | |
| parent | 8a1c0d322e9b6963f3be6949475983d517d79796 (diff) | |
| download | git-7edba4c45c33ba1e17d88907c1601dc660a44522.zip git-7edba4c45c33ba1e17d88907c1601dc660a44522.tar.gz git-7edba4c45c33ba1e17d88907c1601dc660a44522.tar.bz2 | |
merge-recursive: Restructure showing how to chain more process_* functions
In 3734893 (merge-recursive: Fix D/F conflicts 2010-07-09),
process_df_entry() was added to process_renames() and process_entry() but
in a somewhat restrictive manner. Modify the code slightly to make it
clearer how we could chain more such functions if necessary, and alter
process_df_entry() to handle such chaining.
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'merge-recursive.c')
| -rw-r--r-- | merge-recursive.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/merge-recursive.c b/merge-recursive.c index 51c0536..7db1538 100644 --- a/merge-recursive.c +++ b/merge-recursive.c @@ -1259,9 +1259,8 @@ static int process_df_entry(struct merge_options *o, const char *conf; struct stat st; - /* We currently only handle D->F cases */ - assert((!o_sha && a_sha && !b_sha) || - (!o_sha && !a_sha && b_sha)); + if (!((!o_sha && a_sha && !b_sha) || (!o_sha && !a_sha && b_sha))) + return 1; /* we don't handle non D-F cases */ entry->processed = 1; @@ -1350,6 +1349,12 @@ int merge_trees(struct merge_options *o, && !process_df_entry(o, path, e)) clean = 0; } + for (i = 0; i < entries->nr; i++) { + struct stage_data *e = entries->items[i].util; + if (!e->processed) + die("Unprocessed path??? %s", + entries->items[i].string); + } string_list_clear(re_merge, 0); string_list_clear(re_head, 0); |