path: root/lockfile.h
diff options
authorDenton Liu <>2019-04-29 08:28:14 (GMT)
committerJunio C Hamano <>2019-05-05 06:20:06 (GMT)
commit554544276a604c144df45efcb060c80aa322088c (patch)
treece55b3dc9ca47c326991ecfc06a2b1103f60be3a /lockfile.h
parentffac537e6cbbf934b08745a378932722df287a53 (diff)
*.[ch]: remove extern from function declarations using spatch
There has been a push to remove extern from function declarations. Remove some instances of "extern" for function declarations which are caught by Coccinelle. Note that Coccinelle has some difficulty with processing functions with `__attribute__` or varargs so some `extern` declarations are left behind to be dealt with in a future patch. This was the Coccinelle patch used: @@ type T; identifier f; @@ - extern T f(...); and it was run with: $ git ls-files \*.{c,h} | grep -v ^compat/ | xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place Files under `compat/` are intentionally excluded as some are directly copied from external sources and we should avoid churning them as much as possible. Signed-off-by: Denton Liu <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'lockfile.h')
1 files changed, 5 insertions, 5 deletions
diff --git a/lockfile.h b/lockfile.h
index 35403cc..c81983a 100644
--- a/lockfile.h
+++ b/lockfile.h
@@ -159,7 +159,7 @@ struct lock_file {
* timeout_ms is -1, retry indefinitely. The flags argument and error
* handling are described above.
-extern int hold_lock_file_for_update_timeout(
+int hold_lock_file_for_update_timeout(
struct lock_file *lk, const char *path,
int flags, long timeout_ms);
@@ -188,7 +188,7 @@ static inline int is_lock_file_locked(struct lock_file *lk)
* of `hold_lock_file_for_update()` to lock `path`. `err` should be the
* `errno` set by the failing call.
-extern void unable_to_lock_message(const char *path, int err,
+void unable_to_lock_message(const char *path, int err,
struct strbuf *buf);
@@ -197,7 +197,7 @@ extern void unable_to_lock_message(const char *path, int err,
* `errno` set by the failing
* call.
-extern NORETURN void unable_to_lock_die(const char *path, int err);
+NORETURN void unable_to_lock_die(const char *path, int err);
* Associate a stdio stream with the lockfile (which must still be
@@ -234,7 +234,7 @@ static inline FILE *get_lock_file_fp(struct lock_file *lk)
* Return the path of the file that is locked by the specified
* lock_file object. The caller must free the memory.
-extern char *get_locked_file_path(struct lock_file *lk);
+char *get_locked_file_path(struct lock_file *lk);
* If the lockfile is still open, close it (and the file pointer if it
@@ -282,7 +282,7 @@ static inline int reopen_lock_file(struct lock_file *lk)
* call `commit_lock_file()` for a `lock_file` object that is not
* currently locked.
-extern int commit_lock_file(struct lock_file *lk);
+int commit_lock_file(struct lock_file *lk);
* Like `commit_lock_file()`, but rename the lockfile to the provided