summaryrefslogtreecommitdiff
path: root/lockfile.c
diff options
context:
space:
mode:
authorMichael Haggerty <mhagger@alum.mit.edu>2014-10-01 10:28:33 (GMT)
committerJunio C Hamano <gitster@pobox.com>2014-10-01 20:51:29 (GMT)
commit5025d8450a4c8bf9d22a202433072bee780b9b72 (patch)
treec929d7b6dc017172c55b6c363aca236c42732c11 /lockfile.c
parentcf6950d3bfe1447ac04867b1f5654a2fc9c5db96 (diff)
downloadgit-5025d8450a4c8bf9d22a202433072bee780b9b72.zip
git-5025d8450a4c8bf9d22a202433072bee780b9b72.tar.gz
git-5025d8450a4c8bf9d22a202433072bee780b9b72.tar.bz2
resolve_symlink(): use a strbuf for internal scratch space
Aside from shortening and simplifying the code, this removes another place where the path name length is arbitrarily limited. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'lockfile.c')
-rw-r--r--lockfile.c33
1 files changed, 12 insertions, 21 deletions
diff --git a/lockfile.c b/lockfile.c
index 85c8648..cc9b9cb 100644
--- a/lockfile.c
+++ b/lockfile.c
@@ -126,44 +126,35 @@ static char *last_path_elm(char *p)
static char *resolve_symlink(char *p, size_t s)
{
int depth = MAXDEPTH;
+ static struct strbuf link = STRBUF_INIT;
while (depth--) {
- char link[PATH_MAX];
- int link_len = readlink(p, link, sizeof(link));
- if (link_len < 0) {
- /* not a symlink anymore */
- return p;
- }
- else if (link_len < sizeof(link))
- /* readlink() never null-terminates */
- link[link_len] = '\0';
- else {
- warning("%s: symlink too long", p);
- return p;
- }
+ if (strbuf_readlink(&link, p, strlen(p)) < 0)
+ break;
- if (is_absolute_path(link)) {
+ if (is_absolute_path(link.buf)) {
/* absolute path simply replaces p */
- if (link_len < s)
- strcpy(p, link);
+ if (link.len < s)
+ strcpy(p, link.buf);
else {
warning("%s: symlink too long", p);
- return p;
+ break;
}
} else {
/*
- * link is a relative path, so I must replace the
+ * link is a relative path, so replace the
* last element of p with it.
*/
char *r = (char *)last_path_elm(p);
- if (r - p + link_len < s)
- strcpy(r, link);
+ if (r - p + link.len < s)
+ strcpy(r, link.buf);
else {
warning("%s: symlink too long", p);
- return p;
+ break;
}
}
}
+ strbuf_reset(&link);
return p;
}