path: root/list-objects.c
diff options
authorShawn O. Pearce <>2007-11-09 11:06:10 (GMT)
committerJunio C Hamano <>2007-11-10 09:52:54 (GMT)
commit295dd2ad201c0ebb281563750a13d904bd466e01 (patch)
treee46bff288f44da5c22c05b94212c5225b0767187 /list-objects.c
parentb9217c09386e5313ac6a54cc91cf03149514154b (diff)
Fix memory leak in traverse_commit_list
If we were listing objects too then the objects were buffered in an array only reachable from a stack allocated structure. When this function returns that array would be leaked as nobody would have a reference to it anymore. Historically this hasn't been a problem as the primary user of traverse_commit_list() (the noble git-rev-list) would terminate as soon as the function was finished, thus allowing the operating system to cleanup memory. However we have been leaking this data in git-pack-objects ever since that program learned how to run the revision listing internally, rather than relying on reading object names from git-rev-list. To better facilitate reuse of traverse_commit_list during other builtin tools (such as git-fetch) we shouldn't leak temporary memory like this and instead we need to clean up properly after ourselves. Signed-off-by: Shawn O. Pearce <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'list-objects.c')
1 files changed, 7 insertions, 0 deletions
diff --git a/list-objects.c b/list-objects.c
index e5c88c2..4ef58e7 100644
--- a/list-objects.c
+++ b/list-objects.c
@@ -170,4 +170,11 @@ void traverse_commit_list(struct rev_info *revs,
for (i = 0; i <; i++)
+ free(objects.objects);
+ if (revs-> {
+ free(revs->pending.objects);
+ revs-> = 0;
+ revs->pending.alloc = 0;
+ revs->pending.objects = NULL;
+ }