summaryrefslogtreecommitdiff
path: root/lib/shortcut.tcl
diff options
context:
space:
mode:
authorShawn O. Pearce <spearce@spearce.org>2007-09-14 05:50:09 (GMT)
committerShawn O. Pearce <spearce@spearce.org>2007-09-14 05:51:18 (GMT)
commit31bb1d1b2d1e893836b0d2b091fed9e39ee84853 (patch)
tree88f778a7c48f2941c5c89a137c0f162eab68250d /lib/shortcut.tcl
parentbba060462c8732a5cb46ea00165198a9579517ae (diff)
downloadgit-31bb1d1b2d1e893836b0d2b091fed9e39ee84853.zip
git-31bb1d1b2d1e893836b0d2b091fed9e39ee84853.tar.gz
git-31bb1d1b2d1e893836b0d2b091fed9e39ee84853.tar.bz2
git-gui: Paper bag fix missing translated strings
The Tcl expression "[append [mc Foo] Bar]" does not return the string "FooBar" after translation; instead it is setting the variable Foo to the value Bar, or if Foo is already defined it is appending Bar onto the end of it. This is *not* what we wanted to have happen here. Tcl's join function is actually the correct function but its default joinStr argument is a single space. Unfortunately all of our call sites do not want an extra space added to their string. So we need a small wrapper function to make the call to join with an empty join string. In C this is (roughly) the job of the strcat function. Since strcat is not yet used at the global level it is a reasonable name to use here. Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Diffstat (limited to 'lib/shortcut.tcl')
-rw-r--r--lib/shortcut.tcl6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/shortcut.tcl b/lib/shortcut.tcl
index d0e63a3..a7674a7 100644
--- a/lib/shortcut.tcl
+++ b/lib/shortcut.tcl
@@ -23,7 +23,7 @@ proc do_windows_shortcut {} {
puts $fd " \"[file normalize $argv0]\""
close $fd
} err]} {
- error_popup [append [mc "Cannot write script:"] "\n\n$err"]
+ error_popup [strcat [mc "Cannot write script:"] "\n\n$err"]
}
}
}
@@ -71,7 +71,7 @@ proc do_cygwin_shortcut {} {
puts $fd " &\""
close $fd
} err]} {
- error_popup [append [mc "Cannot write script:"] "\n\n$err"]
+ error_popup [strcat [mc "Cannot write script:"] "\n\n$err"]
}
}
}
@@ -146,7 +146,7 @@ proc do_macosx_app {} {
file attributes $exe -permissions u+x,g+x,o+x
} err]} {
- error_popup [append [mc "Cannot write icon:"] "\n\n$err"]
+ error_popup [strcat [mc "Cannot write icon:"] "\n\n$err"]
}
}
}