path: root/lib/browser.tcl
diff options
authorShawn O. Pearce <>2007-06-12 03:52:43 (GMT)
committerShawn O. Pearce <>2007-06-12 03:52:43 (GMT)
commit39fa2a983d55b37759b99e67f9f1892879efb775 (patch)
tree1be07eaef87b5c614b4b8559c91ddb62e6342c8a /lib/browser.tcl
parentb2f3bb1b66d9422aa5049f994c6e370a18d89759 (diff)
git-gui: Save geometry before the window layout is damaged
Because Tk does not assure us the order that it will process children in before it destroys the main toplevel we cannot safely save our geometry data during a "bind . <Destroy>" event binding. The geometry may have already changed as a result of a one or more children being removed from the layout. This was pointed out in gitk by Mark Levedahl, and patched over there by commit b6047c5a8166a71e01c6b63ebbb67c6894d95114. So we now also use "wm protocol . WM_DELETE_WINDOW" to detect when the window is closed by the user, and forward that close event to our main do_quit routine. Signed-off-by: Shawn O. Pearce <>
Diffstat (limited to 'lib/browser.tcl')
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/browser.tcl b/lib/browser.tcl
index fd86b11..3d6341b 100644
--- a/lib/browser.tcl
+++ b/lib/browser.tcl
@@ -70,7 +70,6 @@ constructor new {commit} {
bind $w_list <Right> break
bind $w_list <Visibility> [list focus $w_list]
- bind $w_list <Destroy> [list delete_this $this]
set w $w_list
_ls $this $browser_commit
return $this