path: root/imap-send.c
diff options
authorNicolas Morey-Chaisemartin <>2017-12-18 19:11:13 (GMT)
committerJunio C Hamano <>2017-12-18 21:57:06 (GMT)
commit77eac3f89a7b49424e7bb3498d20421878705485 (patch)
tree223db543299064182a1e8c9045b62462f75477d4 /imap-send.c
parent52015aaf9d19c97b52c47c7046058e6d029ff856 (diff)
imap-send: URI encode server folder
When trying to send a patch using 'imap-send' with 'curl' and the following configuration: [imap] folder = "[Gmail]/Drafts" host = imaps:// port = 993 sslverify = false results in the following error, curl_easy_perform() failed: URL using bad/illegal format or missing URL This is a consequence of not URI-encoding the folder portion of the URL which contains characters such as '[' which are not allowed in a URI. According to RFC3986, these characters should be URI-encoded. So, URI-encode the folder before adding it to the URI to ensure it doesn't contain characters that aren't allowed in a URI. Reported-by: Doron Behar <> Signed-off-by: Nicolas Morey-Chaisemartin <> Signed-off-by: Kaartic Sivaraam <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'imap-send.c')
1 files changed, 7 insertions, 1 deletions
diff --git a/imap-send.c b/imap-send.c
index 54e6a80..36c7c1b 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1412,6 +1412,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc, struct credential *cred)
CURL *curl;
struct strbuf path = STRBUF_INIT;
+ char *uri_encoded_folder;
if (curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK)
die("curl_global_init failed");
@@ -1429,7 +1430,12 @@ static CURL *setup_curl(struct imap_server_conf *srvc, struct credential *cred)
if (!path.len || path.buf[path.len - 1] != '/')
strbuf_addch(&path, '/');
- strbuf_addstr(&path, server.folder);
+ uri_encoded_folder = curl_easy_escape(curl, server.folder, 0);
+ if (!uri_encoded_folder)
+ die("failed to encode server folder");
+ strbuf_addstr(&path, uri_encoded_folder);
+ curl_free(uri_encoded_folder);
curl_easy_setopt(curl, CURLOPT_URL, path.buf);