summaryrefslogtreecommitdiff
path: root/ident.c
diff options
context:
space:
mode:
authorJunio C Hamano <junkio@cox.net>2005-11-22 07:44:35 (GMT)
committerJunio C Hamano <junkio@cox.net>2005-11-22 07:44:35 (GMT)
commitc7d77dab9333112cfce8cce51e56005b5e8b4076 (patch)
tree5bc7f67c535dbbbb9340285c82226a8dd6e4afec /ident.c
parent9ce392f4826558357af2b2c7eb6ad876fdb53a91 (diff)
downloadgit-c7d77dab9333112cfce8cce51e56005b5e8b4076.zip
git-c7d77dab9333112cfce8cce51e56005b5e8b4076.tar.gz
git-c7d77dab9333112cfce8cce51e56005b5e8b4076.tar.bz2
git-var: constness and globalness cleanup.
var.c::git_var read function did not have to return writable strings; make it and the functions it points at return const char * instead. ident.c::get_ident() did not need to be global, so make it static. Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'ident.c')
-rw-r--r--ident.c15
1 files changed, 10 insertions, 5 deletions
diff --git a/ident.c b/ident.c
index bc89e1d..ac1c27f 100644
--- a/ident.c
+++ b/ident.c
@@ -156,7 +156,8 @@ static int copy(char *buf, int size, int offset, const char *src)
return offset;
}
-char *get_ident(const char *name, const char *email, const char *date_str)
+static const char *get_ident(const char *name, const char *email,
+ const char *date_str)
{
static char buffer[1000];
char date[50];
@@ -181,12 +182,16 @@ char *get_ident(const char *name, const char *email, const char *date_str)
return buffer;
}
-char *git_author_info(void)
+const char *git_author_info(void)
{
- return get_ident(getenv("GIT_AUTHOR_NAME"), getenv("GIT_AUTHOR_EMAIL"), getenv("GIT_AUTHOR_DATE"));
+ return get_ident(getenv("GIT_AUTHOR_NAME"),
+ getenv("GIT_AUTHOR_EMAIL"),
+ getenv("GIT_AUTHOR_DATE"));
}
-char *git_committer_info(void)
+const char *git_committer_info(void)
{
- return get_ident(getenv("GIT_COMMITTER_NAME"), getenv("GIT_COMMITTER_EMAIL"), getenv("GIT_COMMITTER_DATE"));
+ return get_ident(getenv("GIT_COMMITTER_NAME"),
+ getenv("GIT_COMMITTER_EMAIL"),
+ getenv("GIT_COMMITTER_DATE"));
}