summaryrefslogtreecommitdiff
path: root/http.c
diff options
context:
space:
mode:
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>2018-08-17 13:02:50 (GMT)
committerJunio C Hamano <gitster@pobox.com>2018-08-17 17:08:56 (GMT)
commitce528de023f82d767096b0342b6da8039feff7bc (patch)
tree53e85fcee37cfd8b2611c47915c3acbb53143d00 /http.c
parent53f9a3e157dbbc901a02ac2c73346d375e24978c (diff)
downloadgit-ce528de023f82d767096b0342b6da8039feff7bc.zip
git-ce528de023f82d767096b0342b6da8039feff7bc.tar.gz
git-ce528de023f82d767096b0342b6da8039feff7bc.tar.bz2
refactor various if (x) FREE_AND_NULL(x) to just FREE_AND_NULL(x)
Change the few conditional uses of FREE_AND_NULL(x) to be unconditional. As noted in the standard[1] free(NULL) is perfectly valid, so we might as well leave this check up to the C library. 1. http://pubs.opengroup.org/onlinepubs/9699919799/functions/free.html Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'http.c')
-rw-r--r--http.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/http.c b/http.c
index b4bfbce..4162860 100644
--- a/http.c
+++ b/http.c
@@ -2418,9 +2418,7 @@ void release_http_object_request(struct http_object_request *freq)
close(freq->localfile);
freq->localfile = -1;
}
- if (freq->url != NULL) {
- FREE_AND_NULL(freq->url);
- }
+ FREE_AND_NULL(freq->url);
if (freq->slot != NULL) {
freq->slot->callback_func = NULL;
freq->slot->callback_data = NULL;