path: root/http.c
diff options
authorTay Ray Chuan <>2009-09-09 12:33:50 (GMT)
committerJunio C Hamano <>2009-09-11 08:45:36 (GMT)
commit59b8d38f6e4f19b93c5dc4493ab11706acd101b5 (patch)
treeb989f8f058a3a9745d1b11b8e0b2647fad8d2c8c /http.c
parent90e431152e05d3e8eb80a0db2e81b7cf50ecc745 (diff)
http.c: remove verification of remote packs
Make http.c::fetch_pack_index() no longer check for the remote pack with a HEAD request before fetching the corresponding pack index file. Not only does sending a HEAD request before we do a GET incur a performance penalty, it does not offer any significant error- prevention advantages (pack fetching in the *_http_pack_request() methods is capable of handling any errors on its own). This addresses an issue raised elsewhere: Signed-off-by: Tay Ray Chuan <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'http.c')
1 files changed, 0 insertions, 11 deletions
diff --git a/http.c b/http.c
index d60f7f7..d0cc1b3 100644
--- a/http.c
+++ b/http.c
@@ -869,17 +869,6 @@ static int fetch_pack_index(unsigned char *sha1, const char *base_url)
char *url;
struct strbuf buf = STRBUF_INIT;
- /* Don't use the index if the pack isn't there */
- end_url_with_slash(&buf, base_url);
- strbuf_addf(&buf, "objects/pack/pack-%s.pack", hex);
- url = strbuf_detach(&buf, 0);
- if (http_get_strbuf(url, NULL, 0)) {
- ret = error("Unable to verify pack %s is available",
- hex);
- goto cleanup;
- }
if (has_pack_index(sha1)) {
ret = 0;
goto cleanup;