summaryrefslogtreecommitdiff
path: root/http.c
diff options
context:
space:
mode:
authorDavid Turner <dturner@twosigma.com>2017-04-11 18:13:57 (GMT)
committerJunio C Hamano <gitster@pobox.com>2017-04-14 01:24:32 (GMT)
commit37ee680d9b90fe4c4fc5be4e14f17baf49f6ce59 (patch)
tree1647210565dd94cb2e7116a9980be30ee0fbf105 /http.c
parentb14f27f91770e0f99f64135348977a0ce1c7993a (diff)
downloadgit-37ee680d9b90fe4c4fc5be4e14f17baf49f6ce59.zip
git-37ee680d9b90fe4c4fc5be4e14f17baf49f6ce59.tar.gz
git-37ee680d9b90fe4c4fc5be4e14f17baf49f6ce59.tar.bz2
http.postbuffer: allow full range of ssize_t values
Unfortunately, in order to push some large repos where a server does not support chunked encoding, the http postbuffer must sometimes exceed two gigabytes. On a 64-bit system, this is OK: we just malloc a larger buffer. This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the buffer size. Signed-off-by: David Turner <dturner@twosigma.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'http.c')
-rw-r--r--http.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/http.c b/http.c
index 96d84bb..7bccb36 100644
--- a/http.c
+++ b/http.c
@@ -19,7 +19,7 @@ long int git_curl_ipresolve;
#endif
int active_requests;
int http_is_verbose;
-size_t http_post_buffer = 16 * LARGE_PACKET_MAX;
+ssize_t http_post_buffer = 16 * LARGE_PACKET_MAX;
#if LIBCURL_VERSION_NUM >= 0x070a06
#define LIBCURL_CAN_HANDLE_AUTH_ANY
@@ -331,7 +331,9 @@ static int http_options(const char *var, const char *value, void *cb)
}
if (!strcmp("http.postbuffer", var)) {
- http_post_buffer = git_config_int(var, value);
+ http_post_buffer = git_config_ssize_t(var, value);
+ if (http_post_buffer < 0)
+ warning(_("negative value for http.postbuffer; defaulting to %d"), LARGE_PACKET_MAX);
if (http_post_buffer < LARGE_PACKET_MAX)
http_post_buffer = LARGE_PACKET_MAX;
return 0;