path: root/help.c
diff options
authorJeff King <>2019-03-20 18:03:26 (GMT)
committerJunio C Hamano <>2019-03-21 02:52:11 (GMT)
commit83b0ecf333e518867935f6b12c18294a8a7f5017 (patch)
treeb1cd4afb3ce2e87a00ac59f8b148ce78ca0f83e4 /help.c
parent0e94f7aa730b108f7907cfab1b2a7fba965de442 (diff)
git: read local config in --list-cmds
Normally code that is checking config before we've decided to do setup_git_directory() would use read_early_config(), which uses discover_git_directory() to tentatively see if we're in a repo, and if so to add it to the config sequence. But list_cmds() uses the caching configset mechanism which rightly does not use read_early_config(), because it has no idea if it's being called early. Call setup_git_directory_gently() so we can pick up repo-level config (like completion.commands). Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'help.c')
1 files changed, 0 insertions, 7 deletions
diff --git a/help.c b/help.c
index 520c908..fac7e42 100644
--- a/help.c
+++ b/help.c
@@ -375,13 +375,6 @@ void list_cmds_by_config(struct string_list *list)
const char *cmd_list;
- /*
- * There's no actual repository setup at this point (and even
- * if there is, we don't really care; only global config
- * matters). If we accidentally set up a repository, it's ok
- * too since the caller (git --list-cmds=) should exit shortly
- * anyway.
- */
if (git_config_get_string_const("completion.commands", &cmd_list))