summaryrefslogtreecommitdiff
path: root/grep.c
diff options
context:
space:
mode:
authorSun He <sunheehnus@gmail.com>2014-03-03 09:39:59 (GMT)
committerJunio C Hamano <gitster@pobox.com>2014-03-06 22:03:12 (GMT)
commit50546b15ed1df25837f8b291e6fa5bbcdb84635e (patch)
treeb2e93edbd6dd402b3a771173d5194adbdb5c235f /grep.c
parent6ab4ae2b415c375170309c2b7ace0e4daa8d0215 (diff)
downloadgit-50546b15ed1df25837f8b291e6fa5bbcdb84635e.zip
git-50546b15ed1df25837f8b291e6fa5bbcdb84635e.tar.gz
git-50546b15ed1df25837f8b291e6fa5bbcdb84635e.tar.bz2
Use hashcpy() when copying object names
We invented hashcpy() to keep the abstraction of "object name" behind it. Use it instead of calling memcpy() with hard-coded 20-byte length when moving object names between pieces of memory. Leave ppc/sha1.c as-is, because the function is about the SHA-1 hash algorithm whose output is and will always be 20 bytes. Helped-by: Michael Haggerty <mhagger@alum.mit.edu> Helped-by: Duy Nguyen <pclouds@gmail.com> Signed-off-by: Sun He <sunheehnus@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'grep.c')
-rw-r--r--grep.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/grep.c b/grep.c
index c668034..f5101f7 100644
--- a/grep.c
+++ b/grep.c
@@ -1650,7 +1650,7 @@ void grep_source_init(struct grep_source *gs, enum grep_source_type type,
break;
case GREP_SOURCE_SHA1:
gs->identifier = xmalloc(20);
- memcpy(gs->identifier, identifier, 20);
+ hashcpy(gs->identifier, identifier);
break;
case GREP_SOURCE_BUF:
gs->identifier = NULL;