path: root/
diff options
authorJunio C Hamano <>2010-01-31 19:11:16 (GMT)
committerJunio C Hamano <>2010-01-31 19:33:44 (GMT)
commit9f7a3c19dee2064b24b6b9fd5d6f6e770d4d539c (patch)
treea56763b3f54702ef1b62f73d987a93679a53e04f /
parent6ddf75ae5d0ff55844cd936a1b850ca9ae5abbe5 (diff)
RPM packaging: use %global inside %{!?...}
According to scope of %define lasts until the end brace; earlier RPM up to Fedora 12 didn't necessarily honor the scope, but later versions corrected the bug. Problem and solution both pointed out by Todd Zullinger. Signed-off-by: Junio C Hamano <>
Diffstat (limited to '')
1 files changed, 4 insertions, 1 deletions
diff --git a/ b/
index 0a03108..ee74a5e 100644
--- a/
+++ b/
@@ -98,7 +98,7 @@ BuildRequires: perl(Error)
Perl interface to Git
%define path_settings ETC_GITCONFIG=/etc/gitconfig prefix=%{_prefix} mandir=%{_mandir} htmldir=%{_docdir}/%{name}-%{version}
-%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}
+%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}
%setup -q
@@ -192,6 +192,9 @@ rm -rf $RPM_BUILD_ROOT
# No files for you!
+* Sun Jan 31 2010 Junio C Hamano <>
+- Do not use %define inside %{!?...} construct.
* Sat Jan 30 2010 Junio C Hamano <>
- We don't ship Python bits until a real foreign scm interface comes.