diff options
| author | Josh Steadmon <steadmon@google.com> | 2020-03-20 21:06:15 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-03-23 20:14:53 (GMT) |
| commit | 3d3adaad914441a6e7b916eb8dfd5ae638aab068 (patch) | |
| tree | 19b976864a32cd6a80e8c2c35339db0a39c0aeba /git.c | |
| parent | 98cedd0233ee88e69711f79d1126b6bd772ff5bd (diff) | |
| download | git-3d3adaad914441a6e7b916eb8dfd5ae638aab068.zip git-3d3adaad914441a6e7b916eb8dfd5ae638aab068.tar.gz git-3d3adaad914441a6e7b916eb8dfd5ae638aab068.tar.bz2 | |
trace2: teach Git to log environment variables
Via trace2, Git can already log interesting config parameters (see the
trace2_cmd_list_config() function). However, this can grant an
incomplete picture because many config parameters also allow overrides
via environment variables.
To allow for more complete logs, we add a new trace2_cmd_list_env_vars()
function and supporting implementation, modeled after the pre-existing
config param logging implementation.
Signed-off-by: Josh Steadmon <steadmon@google.com>
Acked-by: Jeff Hostetler <jeffhost@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git.c')
| -rw-r--r-- | git.c | 3 |
1 files changed, 3 insertions, 0 deletions
@@ -351,6 +351,7 @@ static int handle_alias(int *argcp, const char ***argv) trace2_cmd_alias(alias_command, child.args.argv); trace2_cmd_list_config(); + trace2_cmd_list_env_vars(); trace2_cmd_name("_run_shell_alias_"); ret = run_command(&child); @@ -388,6 +389,7 @@ static int handle_alias(int *argcp, const char ***argv) trace2_cmd_alias(alias_command, new_argv); trace2_cmd_list_config(); + trace2_cmd_list_env_vars(); *argv = new_argv; *argcp += count - 1; @@ -439,6 +441,7 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv) trace_argv_printf(argv, "trace: built-in: git"); trace2_cmd_name(p->cmd); trace2_cmd_list_config(); + trace2_cmd_list_env_vars(); validate_cache_entries(the_repository->index); status = p->fn(argc, argv, prefix); |