summaryrefslogtreecommitdiff
path: root/git-whatchanged
diff options
context:
space:
mode:
authorJunio C Hamano <junkio@cox.net>2005-07-23 02:08:32 (GMT)
committerLinus Torvalds <torvalds@g5.osdl.org>2005-07-23 03:34:16 (GMT)
commit5bb2c65aba9161ee77c42002009634e757005b4f (patch)
tree36946783915c59373a17b8537037a147e5d023c1 /git-whatchanged
parent99cff830e0b5d57fb299f1937a46d62602f23c9b (diff)
downloadgit-5bb2c65aba9161ee77c42002009634e757005b4f.zip
git-5bb2c65aba9161ee77c42002009634e757005b4f.tar.gz
git-5bb2c65aba9161ee77c42002009634e757005b4f.tar.bz2
[PATCH] Help scripts that use git-rev-parse to grok args with SP/TAB/LF
The git-rev-parse command uses LF to separate each argument it parses, so its users at least need to set IFS to LF to be able to handle filenames with embedded SPs and TABs. Some commands, however, can take and do expect arguments with embedded LF, notably, "-S" (pickaxe) of diff family, so even this workaround does not work for them. When --sq flag to git-rev-parse is given, instead of showing one argument per line, it outputs arguments quoted for consumption with "eval" by the caller, to remedy this situation. As an example, this patch converts git-whatchanged to use this new feature. Signed-off-by: Junio C Hamano <junkio@cox.net> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'git-whatchanged')
-rwxr-xr-xgit-whatchanged9
1 files changed, 6 insertions, 3 deletions
diff --git a/git-whatchanged b/git-whatchanged
index 6fbd115..85a49fc 100755
--- a/git-whatchanged
+++ b/git-whatchanged
@@ -1,4 +1,7 @@
#!/bin/sh
-git-rev-list $(git-rev-parse --default HEAD --revs-only "$@") |
- git-diff-tree --stdin --pretty -r $(git-rev-parse --no-revs "$@") |
- LESS="$LESS -S" ${PAGER:-less}
+rev_list_args=$(git-rev-parse --sq --default HEAD --revs-only "$@") &&
+diff_tree_args=$(git-rev-parse --sq --no-revs "$@") &&
+
+eval "git-rev-list $rev_list_args" |
+eval "git-diff-tree --stdin --pretty -r $diff_tree_args" |
+LESS="$LESS -S" ${PAGER:-less}