path: root/
diff options
authorStefan Beller <>2018-08-03 22:23:17 (GMT)
committerJunio C Hamano <>2018-08-03 22:37:12 (GMT)
commit9eca701f69b1dfb857a0445ba8a78e2445e9aa2b (patch)
tree60621de6acb71a64d2ee1b606155eeb1eaa24075 /
parentff03d9306c7dbc2011c0a6660359d9074e4a3ab3 (diff)
git-9eca701f69b1dfb857a0445ba8a78e2445e9aa2b.tar.bz2 rename unused variables
The 'mode' variable is not used in cmd_update for its original purpose, rename it to 'dummy' as it only serves the purpose to abort quickly documenting this knowledge. The variable 'stage' is also not used any more in cmd_update, so remove it. This went unnoticed as first each function used the commonly used submodule listing, which was converted in 74703a1e4df (submodule: rewrite `module_list` shell function in C, 2015-09-02). When cmd_update was using its own function starting in 48308681b07 (git submodule update: have a dedicated helper for cloning, 2016-02-29), its removal was missed. A later patch in this series also touches the communication between the submodule helper and, but let's have this as a preparatory patch, as it eases the next patch, which stores the raw data instead of the line printed for this communication. Signed-off-by: Stefan Beller <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to '')
1 files changed, 2 insertions, 2 deletions
diff --git a/ b/
index 5a58812..8caaf27 100755
--- a/
+++ b/
@@ -531,9 +531,9 @@ cmd_update()
"$@" || echo "#unmatched" $?
} | {
- while read -r mode sha1 stage just_cloned sm_path
+ while read -r quickabort sha1 just_cloned sm_path
- die_if_unmatched "$mode" "$sha1"
+ die_if_unmatched "$quickabort" "$sha1"
name=$(git submodule--helper name "$sm_path") || exit
if ! test -z "$update"