summaryrefslogtreecommitdiff
path: root/git-status-script
diff options
context:
space:
mode:
authorPavel Roskin <proski@gnu.org>2005-08-11 03:56:21 (GMT)
committerJunio C Hamano <junkio@cox.net>2005-08-12 01:26:16 (GMT)
commit4d9d62fa7ca01c481d224e2a2187e38ec2f0996a (patch)
tree273d35e3cf278fff4a64824c36571ba385207b63 /git-status-script
parentd9bdd39eee54ebd77bc01235c00e827ddbe892d0 (diff)
downloadgit-4d9d62fa7ca01c481d224e2a2187e38ec2f0996a.zip
git-4d9d62fa7ca01c481d224e2a2187e38ec2f0996a.tar.gz
git-4d9d62fa7ca01c481d224e2a2187e38ec2f0996a.tar.bz2
[PATCH] Trapping exit in tests, using return for errors
I have noticed that "make test" fails without any explanations when the "merge" utility is missing. I don't think tests should be silent in case of failure. It turned out that the particular test was using "exit" to interrupt the test in case of an error. This caused the whole test script to exit. No further tests would be run even if "--immediate" wasn't specified. No error message was printed. This patch does following: All instances of "exit", "exit 1" and "(exit 1)" in tests have been replaced with "return 1". In fact, "(exit 1)" had no effect. File descriptor 5 is duplicated from file descriptor 1. This is needed to print important error messages from tests. New function test_run_() has been introduced. Any "return" in the test would merely cause that function to return without skipping calls to test_failure_() and test_ok_(). The new function also traps "exit" and treats it like a fatal error (in case somebody reintroduces "exit" in the tests). test_expect_failure() and test_expect_success() check both the result of eval and the return value of test_run_(). If the later is not 0, it's always a failure because it indicates the the test didn't complete. Signed-off-by: Pavel Roskin <proski@gnu.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'git-status-script')
0 files changed, 0 insertions, 0 deletions