path: root/
diff options
authorJunio C Hamano <>2006-02-11 20:39:11 (GMT)
committerJunio C Hamano <>2006-02-12 12:59:25 (GMT)
commit4890f62bc02929b174ff5fa0e3656ea3d40f0e57 (patch)
treee8e7510d265e36ab18297f1970a8044d8735278d /
parent16139f9035137ccd81e1e9a9dc203fbede6997a0 (diff)
Avoid using "git-var -l" until it gets fixed.
This is to be nicer to people with unusable GECOS field. "git-var -l" is currently broken in that when used by a user who does not have a usable GECOS field and has not corrected it by exporting GIT_COMMITTER_NAME environment variable it dies when it tries to output GIT_COMMITTER_IDENT (same thing for AUTHOR). "git-pull" used "git-var -l" only because it needed to get a configuration variable before "git-repo-config --get" was introduced. Use the latter tool designed exactly for this purpose. "git-sh-setup" used "git-var GIT_AUTHOR_IDENT" without actually wanting to use its value. The only purpose was to cause the command to check and barf if the repository format version recorded in the $GIT_DIR/config file is too new for us to deal with correctly. Instead, use "repo-config --get" on a random property and see if it die()s, and check if the exit status is 128 (comes from die -- missing variable is reported with exit status 1, so we can tell that case apart). Signed-off-by: Junio C Hamano <>
Diffstat (limited to '')
1 files changed, 5 insertions, 1 deletions
diff --git a/ b/
index 1e638e4..157c7e4 100755
--- a/
+++ b/
@@ -41,7 +41,11 @@ then
# Make sure we are in a valid repository of a vintage we understand.
- GIT_DIR="$GIT_DIR" git-var GIT_AUTHOR_IDENT >/dev/null || exit
+ GIT_DIR="$GIT_DIR" git repo-config --get core.nosuch >/dev/null
+ if test $? == 128
+ then
+ exit
+ fi
GIT_DIR=$(git-rev-parse --git-dir) || exit