path: root/
diff options
authorÆvar Arnfjörð Bjarmason <>2021-01-20 18:27:58 (GMT)
committerJunio C Hamano <>2021-01-21 23:50:01 (GMT)
commitd162b25f9568c0e874570dfdbdae74f767b6836b (patch)
tree65639336c7a43b8e48ce0f7eb630eaea04833834 /
parent6c280b41421db1cf1849c737e60a0d8aa4435d41 (diff)
tests: remove support for GIT_TEST_GETTEXT_POISON
This removes the ability to inject "poison" gettext() messages via the GIT_TEST_GETTEXT_POISON special test setup. I initially added this as a compile-time option in bb946bba761 (i18n: add GETTEXT_POISON to simulate unfriendly translator, 2011-02-22), and most recently modified to be toggleable at runtime in 6cdccfce1e0 (i18n: make GETTEXT_POISON a runtime option, 2018-11-08).. The reason for its removal is that the trade-off of maintaining it v.s. what it's getting us has long since flipped. When gettext was integrated in 5e9637c6297 (i18n: add infrastructure for translating Git with gettext, 2011-11-18) there was understandable concern on the Git ML that in marking messages for translation en-masse we'd inadvertently mark plumbing messages. The GETTEXT_POISON facility was a way to smoke those out via our test suite. Nowadays however we're done (or almost entirely done) with any marking of messages for translation. New messages are usually marked by their authors, who'll know whether it makes sense to translate them or not. If not any errors in marking the messages are much more likely to be spotted in review than in the the initial deluge of i18n patches in the 2011-2012 era. So let's just remove this. This leaves the test suite in a state where we still have a lot of test_i18n, C_LOCALE_OUTPUT etc. uses. Subsequent commits will remove those too. The change to t/ is a selective revert of the relevant part of f2d17068fd (i18n: rebase-interactive: mark comments of squash for translation, 2016-06-17), and the comment in t/ is from c7108bf9ed (i18n: rebase: mark messages for translation, 2012-07-25). Signed-off-by: Ævar Arnfjörð Bjarmason <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to '')
1 files changed, 1 insertions, 21 deletions
diff --git a/ b/
index 8eef60b..e3d9f48 100644
--- a/
+++ b/
@@ -17,12 +17,7 @@ export TEXTDOMAINDIR
# First decide what scheme to use...
-if test -n "$GIT_TEST_GETTEXT_POISON" &&
- git env--helper --type=bool --default=0 --exit-code \
-elif test -n "@@USE_GETTEXT_SCHEME@@"
+if test -n "@@USE_GETTEXT_SCHEME@@"
@@ -63,21 +58,6 @@ gettext_without_eval_gettext)
- # Emit garbage so that tests that incorrectly rely on translatable
- # strings will fail.
- gettext () {
- printf "%s" "# GETTEXT POISON #"
- }
- eval_gettext () {
- printf "%s" "# GETTEXT POISON #"
- }
- eval_ngettext () {
- printf "%s" "# GETTEXT POISON #"
- }
- ;;
gettext () {
printf "%s" "$1"