summaryrefslogtreecommitdiff
path: root/git-send-email.perl
diff options
context:
space:
mode:
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>2010-09-30 13:42:56 (GMT)
committerJunio C Hamano <gitster@pobox.com>2010-09-30 19:20:32 (GMT)
commitf9237e61576c9bd1ba6a00276a9a849a4b5354fb (patch)
tree6fb1e9ba1584ac78c9cc6fe15befb31418e11e0f /git-send-email.perl
parentfe0f944f3bbe4adac815808654b16837a05905fc (diff)
downloadgit-f9237e61576c9bd1ba6a00276a9a849a4b5354fb.zip
git-f9237e61576c9bd1ba6a00276a9a849a4b5354fb.tar.gz
git-f9237e61576c9bd1ba6a00276a9a849a4b5354fb.tar.bz2
send-email: use lexical filehandles during sending
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.comReviewed-by: Avery Pennarun <apenwarr@gmail.com> Reviewed-by: Jeff King <peff@peff.net> > Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-send-email.perl')
-rwxr-xr-xgit-send-email.perl14
1 files changed, 7 insertions, 7 deletions
diff --git a/git-send-email.perl b/git-send-email.perl
index 634835c..488d894 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1144,7 +1144,7 @@ $subject = $initial_subject;
$message_num = 0;
foreach my $t (@files) {
- open(F,"<",$t) or die "can't open file $t";
+ open my $fh, "<", $t or die "can't open file $t";
my $author = undef;
my $author_encoding;
@@ -1157,7 +1157,7 @@ foreach my $t (@files) {
$message = "";
$message_num++;
# First unfold multiline header fields
- while(<F>) {
+ while(<$fh>) {
last if /^\s*$/;
if (/^\s+\S/ and @header) {
chomp($header[$#header]);
@@ -1233,7 +1233,7 @@ foreach my $t (@files) {
}
}
# Now parse the message body
- while(<F>) {
+ while(<$fh>) {
$message .= $_;
if (/^(Signed-off-by|Cc): (.*)$/i) {
chomp;
@@ -1250,12 +1250,12 @@ foreach my $t (@files) {
$c, $_) unless $quiet;
}
}
- close F;
+ close $fh;
if (defined $cc_cmd && !$suppress_cc{'cccmd'}) {
- open(F, "$cc_cmd \Q$t\E |")
+ open my $fh, "$cc_cmd \Q$t\E |"
or die "(cc-cmd) Could not execute '$cc_cmd'";
- while(<F>) {
+ while(<$fh>) {
my $c = $_;
$c =~ s/^\s*//g;
$c =~ s/\n$//g;
@@ -1264,7 +1264,7 @@ foreach my $t (@files) {
printf("(cc-cmd) Adding cc: %s from: '%s'\n",
$c, $cc_cmd) unless $quiet;
}
- close F
+ close $fh
or die "(cc-cmd) failed to close pipe to '$cc_cmd'";
}