diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-04-02 11:34:33 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-04-02 21:32:29 (GMT) |
| commit | b362acf575424bcfea6444ce6cbfe3c3aa3f1192 (patch) | |
| tree | 13199bd53b30ee887bf4441279ba1cffbe9e4afc /git-send-email.perl | |
| parent | a65ce7f831aa5fcc596c6d23fcde543d98b39bd7 (diff) | |
| download | git-b362acf575424bcfea6444ce6cbfe3c3aa3f1192.zip git-b362acf575424bcfea6444ce6cbfe3c3aa3f1192.tar.gz git-b362acf575424bcfea6444ce6cbfe3c3aa3f1192.tar.bz2 | |
git-send-email: replace "map" in void context with "for"
While using "map" instead of "for" or "map" instead of "grep" and
vice-versa makes for interesting trivia questions when interviewing
Perl programmers, it doesn't make for very readable code. Let's
refactor this loop initially added in 8fd5bb7f44b (git send-email: add
--annotate option, 2008-11-11) to be a for-loop instead.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-send-email.perl')
| -rwxr-xr-x | git-send-email.perl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/git-send-email.perl b/git-send-email.perl index f5bbf16..6893c8e 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -217,12 +217,12 @@ sub do_edit { $editor = Git::command_oneline('var', 'GIT_EDITOR'); } if (defined($multiedit) && !$multiedit) { - map { + for (@_) { system('sh', '-c', $editor.' "$@"', $editor, $_); if (($? & 127) || ($? >> 8)) { die(__("the editor exited uncleanly, aborting everything")); } - } @_; + } } else { system('sh', '-c', $editor.' "$@"', $editor, @_); if (($? & 127) || ($? >> 8)) { |