path: root/
diff options
authorBrandon Casey <>2010-06-02 00:13:41 (GMT)
committerJunio C Hamano <>2010-06-02 16:28:12 (GMT)
commit53dfac44c93d5861f0ab60fc38e1a2d3b67e8c62 (patch)
tree2c53e8dfe17f672b05976782ae520fb6a64299a3 /
parent2bf1033478a65c1067e1a7922a91406c797852ed (diff)
git-53dfac44c93d5861f0ab60fc38e1a2d3b67e8c62.tar.bz2 remove -e switch to shell interpreter which breaks ksh
The -e option causes the shell to exit immediately when a command exits with a non-zero exit status. This does not seem to cause a problem for Bash, but it does cause a problem for the Korn shell, like Solaris's xpg4/sh, whose unset utility returns non-zero if it is passed a variable name which was not previously set. When using xpg4/sh, git-request-pull exits while sourcing git-sh-setup since git-sh-setup tries to unset the CDPATH environment variable. When git-request-pull was originally written, it did not do any error checking and it used this shell feature to exit when an error occurred. This script now performs proper error checking and provides useful error messages, so this -e option appears to be merely a historical artifact and can be removed. Kudos to Jonathan Nieder for introducing t5150 which exercises the request-pull code path. Suggested-by: Brandon Casey <> Signed-off-by: Jonathan Nieder <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to '')
1 files changed, 6 insertions, 6 deletions
diff --git a/ b/
index 74238b0..6fdea39 100755
--- a/
+++ b/
@@ -1,4 +1,4 @@
-#!/bin/sh -e
# Copyright 2005, Ryan Anderson <>
# This file is licensed under the GPL v2, or a later version
@@ -70,10 +70,10 @@ git show -s --format='The following changes since commit %H:
%s (%ci)
-are available in the git repository at:' $baserev
-echo " $url $branch"
+are available in the git repository at:' $baserev &&
+echo " $url $branch" &&
+echo &&
-git shortlog ^$baserev $headrev
-git diff -M --stat --summary $patch $merge_base..$headrev
+git shortlog ^$baserev $headrev &&
+git diff -M --stat --summary $patch $merge_base..$headrev || exit
exit $status