path: root/
diff options
authorJonathan Nieder <>2010-04-24 12:15:37 (GMT)
committerJunio C Hamano <>2010-05-01 18:02:21 (GMT)
commit50ab6558bf688e15048e189bdaf9174b217e1748 (patch)
treed09eb13f6905d997371e38e5edd4e39b53757f06 /
parent30c56eaa2e7ab230a89a6fdc76682d2afaf5d4b1 (diff)
request-pull: protect against OPTIONS_KEEPDASHDASH from environment
Like most git commands, request-pull supports a -- delimiter to allow callers to pass arguments that would otherwise be treated as an option afterwards. The internal OPTIONS_KEEPDASHDASH variable is passed empty to git-sh-setup to indicate that request-pull itself does not care about the position of the -- delimiter. But if the user has that variable in her environment, request-pull will see the “--” and fail. Empty it explicitly to guard against this. While at it, make the corresponding fix to git-resurrect, too (all other scripts in git.git already protect themselves). Acked-by: Thomas Rast <> Acked-by: Miklos Vajna <> Signed-off-by: Jonathan Nieder <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to '')
1 files changed, 1 insertions, 0 deletions
diff --git a/ b/
index 630cedd..b0a0311 100755
--- a/
+++ b/
@@ -8,6 +8,7 @@ USAGE='<start> <url> [<end>]'
LONG_USAGE='Summarizes the changes between two commits to the standard output,
and includes the given URL in the generated summary.'
OPTIONS_SPEC='git request-pull [options] start url [end]
p show patch text as well