summaryrefslogtreecommitdiff
path: root/git-p4.py
diff options
context:
space:
mode:
authorBen Keene <seraphire@gmail.com>2020-02-14 14:44:46 (GMT)
committerJunio C Hamano <gitster@pobox.com>2020-02-14 16:58:53 (GMT)
commit1ec4a0a356f73ef0ab57d3903bd6667942a7052c (patch)
treec4f5d45b2865ada5af4fedb74e5564b481bc85d1 /git-p4.py
parent38ecf75244c4cab93ecb201afff8980c29f56ce8 (diff)
downloadgit-1ec4a0a356f73ef0ab57d3903bd6667942a7052c.zip
git-1ec4a0a356f73ef0ab57d3903bd6667942a7052c.tar.gz
git-1ec4a0a356f73ef0ab57d3903bd6667942a7052c.tar.bz2
git-p4: add RCS keyword status message
During the p4 submit process, git-p4 will attempt to apply a patch to the files found in the p4 workspace. However, if P4 uses RCS keyword expansion, this patch may fail. When the patch fails, the user is alerted to the failure and that git-p4 will attempt to clear the expanded text from the files and re-apply the patch. The current version of git-p4 does not tell the user the result of the re-apply attempt after the RCS expansion has been removed which can be confusing. Add a new print statement after the git patch has been successfully applied when the RCS keywords have been cleansed. Signed-off-by: Ben Keene <seraphire@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-p4.py')
-rwxr-xr-xgit-p4.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/git-p4.py b/git-p4.py
index 8761c70..258b9b9 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -2025,6 +2025,9 @@ class P4Submit(Command, P4UserMap):
applyPatchCmd = patchcmd + "--check --apply -"
patch_succeeded = True
+ if verbose:
+ print("TryPatch: %s" % tryPatchCmd)
+
if os.system(tryPatchCmd) != 0:
fixed_rcs_keywords = False
patch_succeeded = False
@@ -2064,6 +2067,7 @@ class P4Submit(Command, P4UserMap):
print("Retrying the patch with RCS keywords cleaned up")
if os.system(tryPatchCmd) == 0:
patch_succeeded = True
+ print("Patch succeesed this time with RCS keywords cleaned")
if not patch_succeeded:
for f in editedFiles: