path: root/
diff options
authorJunio C Hamano <>2007-09-12 23:04:22 (GMT)
committerJunio C Hamano <>2007-09-12 23:40:59 (GMT)
commit80bffaf7fbe09ef62ecb9a6ffea70ac0171b456c (patch)
tree5c9445287b5c57528d62efc701309bd12b40e671 /
parent88b7dd4597b11db4a99537519df91265fc7533e0 (diff)
git-commit: Allow partial commit of file removal.
When making a partial commit, git-commit uses git-ls-files with the --error-unmatch option to expand and sanity check the user supplied path patterns. When any path pattern does not match with the paths known to the index, it errors out, in order to catch a common mistake to say "git commit Makefiel cache.h" and end up with a commit that touches only cache.h (notice the misspelled "Makefile"). This detection however does not work well when the path has already been removed from the index. If you drop a path from the index and try to commit that partially, i.e. $ git rm COPYING $ git commit -m 'Remove COPYING' COPYING the command complains because git does not know anything about COPYING anymore. This introduces a new option --with-tree to git-ls-files and uses it in git-commit when we build a temporary index to write a tree object for the partial commit. When --with-tree=<tree-ish> option is specified, names from the given tree are added to the set of names the index knows about, so we can treat COPYING file in the example as known. Of course, there is no reason to use "git rm" and git-aware people have long time done: $ rm COPYING $ git commit -m 'Remove COPYING' COPYING which works just fine. But this caused a constant confusion. Signed-off-by: Junio C Hamano <>
Diffstat (limited to '')
1 files changed, 4 insertions, 1 deletions
diff --git a/ b/
index 41538f1..5ea3fd0 100755
--- a/
+++ b/
@@ -379,8 +379,11 @@ t,)
refuse_partial "Cannot do a partial commit during a merge."
- commit_only=`git ls-files --error-unmatch -- "$@"` || exit
+ W=
+ test -z "$initial_commit" && W=--with-tree=HEAD
+ commit_only=`git ls-files --error-unmatch $W -- "$@"` || exit
# Build a temporary index and update the real index
# the same way.