path: root/
diff options
authorGerrit Pape <>2008-05-05 07:43:00 (GMT)
committerJunio C Hamano <>2008-05-06 00:18:20 (GMT)
commitee831f7ddfc40e9144208c93e24d20ff0ad69194 (patch)
treebe7a81b489709ead6ebbbb6a0c662dca1f1add84 /
parent6233a5210ef64ba31bbf0e867e03e9176e0aace9 (diff)
git-ee831f7ddfc40e9144208c93e24d20ff0ad69194.tar.bz2 don't accidentally override existing branch "bisect"
If a branch named "bisect" or "new-bisect" already was created in the repo by other means than git bisect, doing a git bisect used to override the branch without a warning. Now if the branch "bisect" or "new-bisect" already exists, and it was not created by git bisect itself, git bisect start fails with an appropriate error message. Additionally, if checking out a new bisect state fails due to a merge problem, git bisect cleans up the temporary branch "new-bisect". The accidental override has been noticed by Andres Salomon, reported through Signed-off-by: Gerrit Pape <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to '')
1 files changed, 12 insertions, 7 deletions
diff --git a/ b/
index 8e57e9a..54bfd71 100755
--- a/
+++ b/
@@ -65,14 +65,19 @@ bisect_start() {
head=$(GIT_DIR="$GIT_DIR" git symbolic-ref -q HEAD) ||
head=$(GIT_DIR="$GIT_DIR" git rev-parse --verify HEAD) ||
die "Bad HEAD - I need a HEAD"
+ #
+ # Check that we either already have BISECT_START, or that the
+ # branches bisect, new-bisect don't exist, to not override them.
+ #
+ test -s "$GIT_DIR/BISECT_START" ||
+ if git show-ref --verify -q refs/heads/bisect ||
+ git show-ref --verify -q refs/heads/new-bisect; then
+ die 'The branches "bisect" and "new-bisect" must not exist.'
+ fi
case "$head" in
- if [ -s "$GIT_DIR/BISECT_START" ]; then
- branch=`cat "$GIT_DIR/BISECT_START"`
- else
- branch=master
- fi
+ branch=`cat "$GIT_DIR/BISECT_START"`
git checkout $branch || exit
@@ -324,8 +329,8 @@ bisect_next() {
exit_if_skipped_commits "$bisect_rev"
echo "Bisecting: $bisect_nr revisions left to test after this"
- git branch -f new-bisect "$bisect_rev"
- git checkout -q new-bisect || exit
+ git branch -D new-bisect 2> /dev/null
+ git checkout -q -b new-bisect "$bisect_rev" || exit
git branch -M new-bisect bisect
git show-branch "$bisect_rev"