summaryrefslogtreecommitdiff
path: root/git-bisect.sh
diff options
context:
space:
mode:
authorChristian Couder <chriscool@tuxfamily.org>2008-12-02 13:53:47 (GMT)
committerJunio C Hamano <gitster@pobox.com>2008-12-02 23:29:12 (GMT)
commit1a66a489d09e7b8629fa7e4184c78703f4eed335 (patch)
tree6a5a93e511e07990077661746dc76b3bb6c8f208 /git-bisect.sh
parentff3c0ff20e2c0b2c78d2c2da9ce4eb0739ff6ced (diff)
downloadgit-1a66a489d09e7b8629fa7e4184c78703f4eed335.zip
git-1a66a489d09e7b8629fa7e4184c78703f4eed335.tar.gz
git-1a66a489d09e7b8629fa7e4184c78703f4eed335.tar.bz2
bisect: fix "git bisect skip <commit>" and add tests cases
The patch that allows "git bisect skip" to be passed a range of commits using the "<commit1>..<commit2>" notation is flawed because it introduces a regression when it was passed a simple rev or commit. "git bisect skip <commit>" doesn't work any more, because <commit> is quoted but not properly unquoted. This patch fixes that and add tests cases to better check when it is passed commits and range of commits. While at it, this patch also properly quotes the non range arguments using the "sq" function. Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Diffstat (limited to 'git-bisect.sh')
-rwxr-xr-xgit-bisect.sh4
1 files changed, 2 insertions, 2 deletions
diff --git a/git-bisect.sh b/git-bisect.sh
index 6706bc1..ddbdba8 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -199,11 +199,11 @@ bisect_skip() {
*..*)
revs=$(git rev-list "$arg") || die "Bad rev input: $arg" ;;
*)
- revs="'$arg'" ;;
+ revs=$(sq "$arg") ;;
esac
all="$all $revs"
done
- bisect_state 'skip' $all
+ eval bisect_state 'skip' $all
}
bisect_state() {