summaryrefslogtreecommitdiff
path: root/fsck.h
diff options
context:
space:
mode:
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>2021-03-28 13:15:41 (GMT)
committerJunio C Hamano <gitster@pobox.com>2021-03-29 02:03:10 (GMT)
commit30cf618eef09573a2f411e0b420e19f2f2e5a1c1 (patch)
treea8e0394897e3e0a793c3e26f63c7b77ae9743b0e /fsck.h
parent1b32b59f9bd78b3475195a6e99c629a5ffefdea0 (diff)
downloadgit-30cf618eef09573a2f411e0b420e19f2f2e5a1c1.zip
git-30cf618eef09573a2f411e0b420e19f2f2e5a1c1.tar.gz
git-30cf618eef09573a2f411e0b420e19f2f2e5a1c1.tar.bz2
fsck.h: re-order and re-assign "enum fsck_msg_type"
Change the values in the "enum fsck_msg_type" from being manually assigned to using default C enum values. This means we end up with a FSCK_IGNORE=0, which was previously defined as "2". I'm confident that nothing relies on these values, we always compare them for equality. Let's not omit "0" so it won't be assumed that we're using these as a boolean somewhere. This also allows us to re-structure the fields to mark which are "private" v.s. "public". See the preceding commit for a rationale for not simply splitting these into two enums, namely that this is used for both the private and public fsck API. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'fsck.h')
-rw-r--r--fsck.h10
1 files changed, 6 insertions, 4 deletions
diff --git a/fsck.h b/fsck.h
index baf3762..a7e092d 100644
--- a/fsck.h
+++ b/fsck.h
@@ -4,11 +4,13 @@
#include "oidset.h"
enum fsck_msg_type {
- FSCK_INFO = -2,
- FSCK_FATAL = -1,
- FSCK_ERROR = 1,
+ /* for internal use only */
+ FSCK_IGNORE,
+ FSCK_INFO,
+ FSCK_FATAL,
+ /* "public", fed to e.g. error_func callbacks */
+ FSCK_ERROR,
FSCK_WARN,
- FSCK_IGNORE
};
struct fsck_options;