summaryrefslogtreecommitdiff
path: root/fsck.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2008-03-04 10:02:35 (GMT)
committerJunio C Hamano <gitster@pobox.com>2008-03-05 18:32:01 (GMT)
commit79b1138e7894ea048008f6b99908f5cd36e94949 (patch)
tree22ce33a3dc57a1f22208a104bf700efacce45fd7 /fsck.c
parentc95b3ad9ea310ec89e31a21edecaaf2c374e2c46 (diff)
downloadgit-79b1138e7894ea048008f6b99908f5cd36e94949.zip
git-79b1138e7894ea048008f6b99908f5cd36e94949.tar.gz
git-79b1138e7894ea048008f6b99908f5cd36e94949.tar.bz2
fsck.c: fix bogus "empty tree" check
ba002f3 (builtin-fsck: move common object checking code to fsck.c) did more than what it claimed to. Most notably, it wrongly made an empty tree object an error by pretending to only move code from fsck_tree() in builtin-fsck.c to fsck_tree() in fsck.c, but in fact adding a bogus check to barf on an empty tree. An empty tree object is _unusual_. Recent porcelains try reasonably hard not to let the user create a commit that contains such a tree. Perhaps warning about them in git-fsck may have some merit. HOWEVER. Being unusual and being errorneous are two quite different things. This is especially true now we seem to use the same fsck_$object() code in places other than git-fsck itself. For example, receive-pack should not reject unusual objects, even if it would be a good idea to tighten it to reject incorrect ones. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'fsck.c')
-rw-r--r--fsck.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fsck.c b/fsck.c
index 6883d1b..797e317 100644
--- a/fsck.c
+++ b/fsck.c
@@ -155,8 +155,6 @@ static int fsck_tree(struct tree *item, int strict, fsck_error error_func)
o_mode = 0;
o_name = NULL;
o_sha1 = NULL;
- if (!desc.size)
- return error_func(&item->object, FSCK_ERROR, "empty tree");
while (desc.size) {
unsigned mode;