summaryrefslogtreecommitdiff
path: root/ewah
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2017-03-05 11:46:38 (GMT)
committerJunio C Hamano <gitster@pobox.com>2017-03-06 20:03:40 (GMT)
commit3255e512a8594cc5f811aea0dd769429c0f0d614 (patch)
treef3f1bfc8f8ec06f340d3e7986f2a64922c2f7b6c /ewah
parent0f9e62e0847c075678a7a5a748567d1e881d16f8 (diff)
downloadgit-3255e512a8594cc5f811aea0dd769429c0f0d614.zip
git-3255e512a8594cc5f811aea0dd769429c0f0d614.tar.gz
git-3255e512a8594cc5f811aea0dd769429c0f0d614.tar.bz2
ewah: fix eword_t/uint64_t confusion
The ewah subsystem typedefs eword_t to be uint64_t, but some code uses a bare uint64_t. This isn't a bug now, but it's a potential maintenance problem if the definition of eword_t ever changes. Let's use the correct type. Note that we can't use COPY_ARRAY() here because the source and destination point to objects of different sizes. For that reason we'll also skip the usual "sizeof(*dst)" and use the real type, which should make it more clear that there's something tricky going on. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ewah')
-rw-r--r--ewah/ewah_io.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/ewah/ewah_io.c b/ewah/ewah_io.c
index f7f700e..84eaf89 100644
--- a/ewah/ewah_io.c
+++ b/ewah/ewah_io.c
@@ -133,8 +133,8 @@ int ewah_read_mmap(struct ewah_bitmap *self, void *map, size_t len)
* the endianness conversion in a separate pass to ensure
* we're loading 8-byte aligned words.
*/
- memcpy(self->buffer, ptr, self->buffer_size * sizeof(uint64_t));
- ptr += self->buffer_size * sizeof(uint64_t);
+ memcpy(self->buffer, ptr, self->buffer_size * sizeof(eword_t));
+ ptr += self->buffer_size * sizeof(eword_t);
for (i = 0; i < self->buffer_size; ++i)
self->buffer[i] = ntohll(self->buffer[i]);