path: root/entry.c
diff options
authorJunio C Hamano <>2009-08-17 06:53:12 (GMT)
committerJunio C Hamano <>2009-08-18 10:32:45 (GMT)
commitda02ca508b842e61c71d920310ff30bbe0238993 (patch)
tree1df912cd8732c7fcd91b33a8b2b847b47dc484f7 /entry.c
parentb6986d8a75812a003a1623e0f0dff93c4a026b44 (diff)
check_path(): allow symlinked directories to checkout-index --prefix
Merlyn noticed that Documentation/ no longer correctly removes old installed documents when the target directory has a leading path that is a symlink. It turns out that "checkout-index --prefix" was broken by recent b6986d8 (git-checkout: be careful about untracked symlinks, 2009-07-29). I suspect has_symlink_leading_path() could learn the third parameter (prefix that is allowed to be symlinked directories) to allow us to retire a similar function has_dirs_only_path(). Another avenue of fixing this I considered was to get rid of base_dir and base_dir_len from "struct checkout", and instead make "git checkout-index" when run with --prefix mkdir the leading path and chdir in there. It might be the best longer term solution to this issue, as the base_dir feature is used only by that rather obscure codepath as far as I know. But at least this patch should fix this breakage. Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'entry.c')
1 files changed, 8 insertions, 4 deletions
diff --git a/entry.c b/entry.c
index f276cf3..06d24f1 100644
--- a/entry.c
+++ b/entry.c
@@ -177,11 +177,15 @@ static int write_entry(struct cache_entry *ce, char *path, const struct checkout
* This is like 'lstat()', except it refuses to follow symlinks
- * in the path.
+ * in the path, after skipping "skiplen".
-int check_path(const char *path, int len, struct stat *st)
+int check_path(const char *path, int len, struct stat *st, int skiplen)
- if (has_symlink_leading_path(path, len)) {
+ const char *slash = path + len;
+ while (path < slash && *slash != '/')
+ slash--;
+ if (!has_dirs_only_path(path, slash - path, skiplen)) {
errno = ENOENT;
return -1;
@@ -201,7 +205,7 @@ int checkout_entry(struct cache_entry *ce, const struct checkout *state, char *t
strcpy(path + len, ce->name);
len += ce_namelen(ce);
- if (!check_path(path, len, &st)) {
+ if (!check_path(path, len, &st, state->base_dir_len)) {
unsigned changed = ce_match_stat(ce, &st, CE_MATCH_IGNORE_VALID);
if (!changed)
return 0;