summaryrefslogtreecommitdiff
path: root/editor.c
diff options
context:
space:
mode:
authorRamkumar Ramachandra <artagnon@gmail.com>2013-07-28 16:59:42 (GMT)
committerJunio C Hamano <gitster@pobox.com>2013-07-29 19:15:27 (GMT)
commit09c5ae5a503b0293205c7e6d63a739bd8d0529dc (patch)
treef5d3880555a649f4af300a07d75c1ad00683a9ca /editor.c
parent117eea7eaaeb5ecb77d9b7cebdb40b4e85f37374 (diff)
downloadgit-09c5ae5a503b0293205c7e6d63a739bd8d0529dc.zip
git-09c5ae5a503b0293205c7e6d63a739bd8d0529dc.tar.gz
git-09c5ae5a503b0293205c7e6d63a739bd8d0529dc.tar.bz2
editor: use canonicalized absolute path
By improving the relative_path() algorithm, e02ca72 (path.c: refactor relative_path(), not only strip prefix, 2013-06-25) uncovered a latent bug in Emacs. While most editor applications like cat and vim handle non-canonicalized relative paths fine, emacs does not. This is due to a long-standing bug in emacs, where it refuses to resolve symlinks in the supplied path: #!/bin/sh cd /tmp mkdir z z/a z/b echo moodle >z/a/file ln -s z/b cd b emacs ../a/file # fail: attempts to open /tmp/a/file Even if emacs were to be patched to fix this bug, it may be nicer to help users running older versions. Note that this can potentially regress for users of all editors, when they ask "what file am I editing?" to the editor, as it is likely to answer with an unsightly long full path. Co-authored-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'editor.c')
-rw-r--r--editor.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/editor.c b/editor.c
index 27bdecd..0abbd8d 100644
--- a/editor.c
+++ b/editor.c
@@ -37,7 +37,7 @@ int launch_editor(const char *path, struct strbuf *buffer, const char *const *en
return error("Terminal is dumb, but EDITOR unset");
if (strcmp(editor, ":")) {
- const char *args[] = { editor, path, NULL };
+ const char *args[] = { editor, real_path(path), NULL };
struct child_process p;
int ret, sig;