path: root/diffcore-rename.c
diff options
authorJunio C Hamano <>2005-11-15 20:48:08 (GMT)
committerJunio C Hamano <>2005-11-15 23:08:27 (GMT)
commit3299c6f6a8a384453d025ffa117c5d8b35ba1972 (patch)
treea9067de664756254895eb8d532097d31534b35bc /diffcore-rename.c
parentf8348be3be8493a62110a09ab0343213990b416b (diff)
diff: make default rename detection limit configurable.
A while ago, a rename-detection limit logic was implemented as a response to this thread: where gitweb was found to be using a lot of time and memory to detect renames on huge commits. git-diff family takes -l<num> flag, and if the number of paths that are rename destination candidates (i.e. new paths with -M, or modified paths with -C) are larger than that number, skips rename/copy detection even when -M or -C is specified on the command line. This commit makes the rename detection limit easier to use. You can have: [diff] renamelimit = 30 in your .git/config file to specify the default rename detection limit. You can override this from the command line; giving 0 means 'unlimited': git diff -M -l0 We might want to change the default behaviour, when you do not have the configuration, to limit it to say 20 paths or so. This would also help the diffstat generation after a big 'git pull'. Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'diffcore-rename.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/diffcore-rename.c b/diffcore-rename.c
index e17dd90..6a9d95d 100644
--- a/diffcore-rename.c
+++ b/diffcore-rename.c
@@ -283,7 +283,7 @@ void diffcore_rename(struct diff_options *options)
register_rename_src(p->one, 1);
if (rename_dst_nr == 0 ||
- (0 <= rename_limit && rename_limit < rename_dst_nr))
+ (0 < rename_limit && rename_limit < rename_dst_nr))
goto cleanup; /* nothing to do */
/* We really want to cull the candidates list early