diff options
| author | Jeff King <peff@peff.net> | 2015-12-29 06:35:46 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-01-04 17:51:16 (GMT) |
| commit | 9a93c6686f56086fe5280a85513041bbfebf41d0 (patch) | |
| tree | 7e8ceeeb6f3e52f99e94e968145f5cf46d508080 /diff.h | |
| parent | 1ff88560c8d22bcdb528a6629239d638f927cb96 (diff) | |
| download | git-9a93c6686f56086fe5280a85513041bbfebf41d0.zip git-9a93c6686f56086fe5280a85513041bbfebf41d0.tar.gz git-9a93c6686f56086fe5280a85513041bbfebf41d0.tar.bz2 | |
avoid shifting signed integers 31 bits
We sometimes use 32-bit unsigned integers as bit-fields.
It's fine to access the MSB, because it's unsigned. However,
doing so as "1 << 31" is wrong, because the constant "1" is
a signed int, and we shift into the sign bit, causing
undefined behavior.
We can fix this by using "1U" as the constant.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'diff.h')
| -rw-r--r-- | diff.h | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -91,7 +91,7 @@ typedef struct strbuf *(*diff_prefix_fn_t)(struct diff_options *opt, void *data) #define DIFF_OPT_DIRSTAT_BY_LINE (1 << 28) #define DIFF_OPT_FUNCCONTEXT (1 << 29) #define DIFF_OPT_PICKAXE_IGNORE_CASE (1 << 30) -#define DIFF_OPT_DEFAULT_FOLLOW_RENAMES (1 << 31) +#define DIFF_OPT_DEFAULT_FOLLOW_RENAMES (1U << 31) #define DIFF_OPT_TST(opts, flag) ((opts)->flags & DIFF_OPT_##flag) #define DIFF_OPT_TOUCHED(opts, flag) ((opts)->touched_flags & DIFF_OPT_##flag) |