path: root/diff.c
diff options
authorThomas Gummerer <>2019-07-11 16:08:48 (GMT)
committerJunio C Hamano <>2019-07-11 21:29:27 (GMT)
commit430be36eb53b042c447201c778b5398df887022f (patch)
tree06f871ccc81faf1069e5735d91c6e7b784d3a1f1 /diff.c
parente1db26308413f5da2cef2c9c3869257d1ed6336b (diff)
range-diff: suppress line count in outer diff
The line count in the outer diff's hunk headers of a range diff is not all that interesting. It merely shows how far along the inner diff are on both sides. That number is of no use for human readers, and range-diffs are not meant to be machine readable. In a subsequent commit we're going to add some more contextual information such as the filename corresponding to the diff to the hunk headers. Remove the unnecessary information, and just keep the "@@" to indicate that a new hunk of the outer diff is starting. Signed-off-by: Thomas Gummerer <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'diff.c')
1 files changed, 4 insertions, 1 deletions
diff --git a/diff.c b/diff.c
index 1ee04e3..4146993 100644
--- a/diff.c
+++ b/diff.c
@@ -1673,7 +1673,10 @@ static void emit_hunk_header(struct emit_callback *ecbdata,
if (ecbdata->opt->flags.dual_color_diffed_diffs)
strbuf_addstr(&msgbuf, reverse);
strbuf_addstr(&msgbuf, frag);
- strbuf_add(&msgbuf, line, ep - line);
+ if (ecbdata->opt->flags.suppress_hunk_header_line_count)
+ strbuf_add(&msgbuf, atat, sizeof(atat));
+ else
+ strbuf_add(&msgbuf, line, ep - line);
strbuf_addstr(&msgbuf, reset);