path: root/diff-no-index.c
diff options
authorThomas Rast <>2012-07-30 19:25:40 (GMT)
committerJunio C Hamano <>2012-07-31 22:05:53 (GMT)
commitb622d4d11d27fd290f7732c6a65f40c054796c1f (patch)
tree3c849f06845d7808482f71105b53a391aca6232c /diff-no-index.c
parentd0f1ea6003d97e63110fa7d50bb07f546a909b6e (diff)
send-email: improve RFC2047 quote parsing
The RFC2047 unquoting, used to parse email addresses in From and Cc headers, is broken in several ways: * It erroneously substitutes ' ' for '_' in *the whole* header, even outside the quoted field. [Noticed by Christoph.] * It is too liberal in its matching, and happily matches the start of one quoted chunk against the end of another, or even just something that looks like such an end. [Noticed by Junio.] * It fundamentally cannot cope with encodings that are not a superset of ASCII, nor several (incompatible) encodings in the same header. This patch fixes the first two by doing a more careful decoding of the outer quoting (e.g. "=AB" to represent an octet whose value is 0xAB). Fixing the fundamental issues is left for a future, more intrusive, patch. Noticed-by: Christoph Miebach <> Helped-by: Junio C Hamano <> Signed-off-by: Thomas Rast <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'diff-no-index.c')
0 files changed, 0 insertions, 0 deletions