diff options
| author | René Scharfe <l.s.r@web.de> | 2021-08-25 20:16:46 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-08-25 21:39:08 (GMT) |
| commit | 66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a (patch) | |
| tree | 4cff22e9d61be87fc5bce6952981e8ba1c7b7127 /csum-file.c | |
| parent | a7439d0f9dd291e7cc9e6c2dda19cbfdf09b62ee (diff) | |
| download | git-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.zip git-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.tar.gz git-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.tar.bz2 | |
use xopen() to handle fatal open(2) failures
Add and apply a semantic patch for using xopen() instead of calling
open(2) and die() or die_errno() explicitly. This makes the error
messages more consistent and shortens the code.
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'csum-file.c')
| -rw-r--r-- | csum-file.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/csum-file.c b/csum-file.c index c951cf8..26e8a6d 100644 --- a/csum-file.c +++ b/csum-file.c @@ -131,12 +131,8 @@ struct hashfile *hashfd_check(const char *name) int sink, check; struct hashfile *f; - sink = open("/dev/null", O_WRONLY); - if (sink < 0) - die_errno("unable to open /dev/null"); - check = open(name, O_RDONLY); - if (check < 0) - die_errno("unable to open '%s'", name); + sink = xopen("/dev/null", O_WRONLY); + check = xopen(name, O_RDONLY); f = hashfd(sink, name); f->check_fd = check; f->check_buffer = xmalloc(f->buffer_len); |