summaryrefslogtreecommitdiff
path: root/credential.h
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2011-12-10 10:31:34 (GMT)
committerJunio C Hamano <gitster@pobox.com>2011-12-12 07:16:25 (GMT)
commita78fbb4fb6c69d96cb91dee9d4733d2326c6d019 (patch)
tree748d1990319b7c91ec3c32b6ee132443e1badc73 /credential.h
parentd5742425ebfd3060fd181195f3be84cd28c1d06f (diff)
downloadgit-a78fbb4fb6c69d96cb91dee9d4733d2326c6d019.zip
git-a78fbb4fb6c69d96cb91dee9d4733d2326c6d019.tar.gz
git-a78fbb4fb6c69d96cb91dee9d4733d2326c6d019.tar.bz2
credential: make relevance of http path configurable
When parsing a URL into a credential struct, we carefully record each part of the URL, including the path on the remote host, and use the result as part of the credential context. This had two practical implications: 1. Credential helpers which store a credential for later access are likely to use the "path" portion as part of the storage key. That means that a request to https://example.com/foo.git would not use the same credential that was stored in an earlier request for: https://example.com/bar.git 2. The prompt shown to the user includes all relevant context, including the path. In most cases, however, users will have a single password per host. The behavior in (1) will be inconvenient, and the prompt in (2) will be overly long. This patch introduces a config option to toggle the relevance of http paths. When turned on, we use the path as before. When turned off, we drop the path component from the context: helpers don't see it, and it does not appear in the prompt. This is nothing you couldn't do with a clever credential helper at the start of your stack, like: [credential "http://"] helper = "!f() { grep -v ^path= ; }; f" helper = your_real_helper But doing this: [credential] useHttpPath = false is way easier and more readable. Furthermore, since most users will want the "off" behavior, that is the new default. Users who want it "on" can set the variable (either for all credentials, or just for a subset using credential.*.useHttpPath). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'credential.h')
-rw-r--r--credential.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/credential.h b/credential.h
index e504272..96ea41b 100644
--- a/credential.h
+++ b/credential.h
@@ -6,7 +6,8 @@
struct credential {
struct string_list helpers;
unsigned approved:1,
- configured:1;
+ configured:1,
+ use_http_path:1;
char *username;
char *password;