path: root/convert.c
diff options
authorDmitry Potapov <>2008-01-16 01:59:12 (GMT)
committerJunio C Hamano <>2008-01-16 17:10:34 (GMT)
commit28624193b2ce622144136d373e136455b6b13967 (patch)
tree1a37e1479070404d958ec63b91e17521de2030c0 /convert.c
parent4439751dcbc3ba2fccae70626654f7950a7b298c (diff)
treat any file with NUL as binary
There are two heuristics in Git to detect whether a file is binary or text. One in xdiff-interface.c (which is taken from GNU diff) relies on existence of the NUL byte at the beginning. However, convert.c used a different heuristic, which relied on the percent of non-printable symbols (less than 1% for text files). Due to differences in detection whether a file is binary or not, it was possible that a file that diff treats as binary could be treated as text by CRLF conversion. This is very confusing for a user who sees that 'git diff' shows the file as binary expects it to be added as binary. This patch makes is_binary to consider any file that contains at least one NUL character as binary, to ensure that the heuristics used for CRLF conversion is tighter than what is used by diff. Signed-off-by: Dmitry Potapov <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'convert.c')
1 files changed, 7 insertions, 2 deletions
diff --git a/convert.c b/convert.c
index 4df7559..80f114b 100644
--- a/convert.c
+++ b/convert.c
@@ -17,8 +17,8 @@
#define CRLF_INPUT 2
struct text_stat {
- /* CR, LF and CRLF counts */
- unsigned cr, lf, crlf;
+ /* NUL, CR, LF and CRLF counts */
+ unsigned nul, cr, lf, crlf;
/* These are just approximations! */
unsigned printable, nonprintable;
@@ -51,6 +51,9 @@ static void gather_stats(const char *buf, unsigned long size, struct text_stat *
case '\b': case '\t': case '\033': case '\014':
+ case 0:
+ stats->nul++;
+ /* fall through */
@@ -66,6 +69,8 @@ static void gather_stats(const char *buf, unsigned long size, struct text_stat *
static int is_binary(unsigned long size, struct text_stat *stats)
+ if (stats->nul)
+ return 1;
if ((stats->printable >> 7) < stats->nonprintable)
return 1;