summaryrefslogtreecommitdiff
path: root/contrib
diff options
context:
space:
mode:
authorBenjamin Sergeant <bsergean@gmail.com>2007-06-08 18:13:55 (GMT)
committerSimon Hausmann <shausman@trolltech.com>2007-06-16 20:06:06 (GMT)
commitda4a660161cfe9d04c0849d77fa460c6ffc6503c (patch)
tree304d8c69bac57ef51451c8f49ab03dd8d937f89d /contrib
parent3c699645f589612065b048ecde45a4ea293dc75f (diff)
downloadgit-da4a660161cfe9d04c0849d77fa460c6ffc6503c.zip
git-da4a660161cfe9d04c0849d77fa460c6ffc6503c.tar.gz
git-da4a660161cfe9d04c0849d77fa460c6ffc6503c.tar.bz2
git-p4 fails when cloning a p4 depo.
A perforce command with all the files in the repo is generated to get all the file content. Here is a patch to break it into multiple successive perforce command who uses 4K of parameter max, and collect the output for later. It works, but not for big depos, because the whole perforce depo content is stored in memory in P4Sync.run(), and it looks like mine is bigger than 2 Gigs, so I had to kill the process. [Simon: I added the bit about using SC_ARG_MAX, as suggested by Han-Wen] Signed-off-by: Benjamin Sergeant <bsergean@gmail.com> Signed-off-by: Simon Hausmann <simon@lst.de>
Diffstat (limited to 'contrib')
-rwxr-xr-xcontrib/fast-import/git-p420
1 files changed, 17 insertions, 3 deletions
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index e527734..d1f8d3b 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -711,9 +711,23 @@ class P4Sync(Command):
if not files:
return
- filedata = p4CmdList('print %s' % ' '.join(['"%s#%s"' % (f['path'],
- f['rev'])
- for f in files]))
+ # We cannot put all the files on the command line
+ # OS have limitations on the max lenght of arguments
+ # POSIX says it's 4096 bytes, default for Linux seems to be 130 K.
+ # and all OS from the table below seems to be higher than POSIX.
+ # See http://www.in-ulm.de/~mascheck/various/argmax/
+ argmax = min(4000, os.sysconf('SC_ARG_MAX'))
+ chunk = ''
+ filedata = []
+ for i in xrange(len(files)):
+ f = files[i]
+ chunk += '"%s#%s" ' % (f['path'], f['rev'])
+ if len(chunk) > argmax or i == len(files)-1:
+ data = p4CmdList('print %s' % chunk)
+ if "p4ExitCode" in data[0]:
+ die("Problems executing p4. Error: [%d]." % (data[0]['p4ExitCode']));
+ filedata.extend(data)
+ chunk = ''
j = 0;
contents = {}