path: root/contrib
diff options
authorJeff King <>2019-11-11 09:04:18 (GMT)
committerJunio C Hamano <>2019-11-13 01:09:10 (GMT)
commitb19f3fe9dd1a0c00fb8b30df9896912727f2eea2 (patch)
tree87e0ddb235f04c3bf1f1ce96366cc39e18d29661 /contrib
parentaa6d7f93edc39361c926e1748fbee3b4243808f8 (diff)
hex: drop sha1_to_hex()
There's only a single caller left of sha1_to_hex(), since everybody that has an object name in "unsigned char[]" now uses hash_to_hex() instead. This case is in the sha1dc wrapper, where we print a hex sha1 when we find a collision. This one will always be sha1, regardless of the current hash algorithm, so we can't use hash_to_hex() here. In practice we'd probably not be running sha1 at all if it isn't the current algorithm, but it's possible we might still occasionally need to compute a sha1 in a post-sha256 world. Since sha1_to_hex() is just a wrapper for hash_to_hex_algop(), let's call that ourselves. There's value in getting rid of the sha1-specific wrapper to de-clutter the global namespace, and to make sure nobody uses it (and as with sha1_to_hex_r() in the previous patch, we'll drop the coccinelle transformations, too). The sha1_to_hex() function is mentioned in a comment; we can easily swap that out for oid_to_hex() to give a better example. Also update the comment that was left stale when we added "struct object_id *" as a way to name an object and added functions to convert it to hex. The function is also mentioned in some test vectors in t4100, but that's not runnable code, so there's no point in trying to clean it up. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'contrib')
1 files changed, 0 insertions, 15 deletions
diff --git a/contrib/coccinelle/object_id.cocci b/contrib/coccinelle/object_id.cocci
index 6c0d21d..ddf4f22 100644
--- a/contrib/coccinelle/object_id.cocci
+++ b/contrib/coccinelle/object_id.cocci
@@ -13,21 +13,6 @@ struct object_id *OIDPTR;
struct object_id OID;
-- sha1_to_hex(OID.hash)
-+ oid_to_hex(&OID)
-identifier f != oid_to_hex;
-struct object_id *OIDPTR;
- f(...) {<...
-- sha1_to_hex(OIDPTR->hash)
-+ oid_to_hex(OIDPTR)
- ...>}
-struct object_id OID;
- hashclr(OID.hash)
+ oidclr(&OID)