path: root/contrib
diff options
authorJeff King <>2019-11-11 09:04:11 (GMT)
committerJunio C Hamano <>2019-11-11 09:11:41 (GMT)
commitaa6d7f93edc39361c926e1748fbee3b4243808f8 (patch)
tree62d350c0fb6a92462fd4ae8e766abe1409474767 /contrib
parentd9f6f3b6195a0ca35642561e530798ad1469bd41 (diff)
hex: drop sha1_to_hex_r()
There are no callers left; everybody uses oid_to_hex_r() or hash_to_hex_algop_r(). This used to actually be the underlying implementation for oid_to_hex_r(), but that's no longer the case since 47edb64997 (hex: introduce functions to print arbitrary hashes, 2018-11-14). Let's get rid of it to de-clutter and to make sure nobody uses it. Likewise we can drop the coccinelle rules that mention it, since the compiler will make it quite clear that the code does not work. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'contrib')
1 files changed, 0 insertions, 17 deletions
diff --git a/contrib/coccinelle/object_id.cocci b/contrib/coccinelle/object_id.cocci
index 3e536a9..6c0d21d 100644
--- a/contrib/coccinelle/object_id.cocci
+++ b/contrib/coccinelle/object_id.cocci
@@ -26,23 +26,6 @@ struct object_id *OIDPTR;
-expression E;
-struct object_id OID;
-- sha1_to_hex_r(E, OID.hash)
-+ oid_to_hex_r(E, &OID)
-identifier f != oid_to_hex_r;
-expression E;
-struct object_id *OIDPTR;
- f(...) {<...
-- sha1_to_hex_r(E, OIDPTR->hash)
-+ oid_to_hex_r(E, OIDPTR)
- ...>}
struct object_id OID;
- hashclr(OID.hash)